feat(alerts): Report in Sentry and headers whether legacy models were used#110954
Merged
feat(alerts): Report in Sentry and headers whether legacy models were used#110954
Conversation
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Mar 18, 2026
| try: | ||
| # Execute the endpoint | ||
| response = func(*args, **kwargs) | ||
| if isinstance(response, HttpResponseBase): |
Member
There was a problem hiding this comment.
Is this mostly for safety, or what other kinds of responses might we expect?
Member
Author
There was a problem hiding this comment.
The decorator doesn't require a particular result type, so this is needed for safety. But also, it's entirely possible other options exist, and this is a little dangerous as if there is some other case that is somehow incompatible, we'd break legacy behavior.
I'm a little worried that some results (streamed, perhaps?) might have runtime enforcement, but I couldn't find evidence of this in base class impls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing, debugging, and analyzing perf impact, it's useful for us to be able to tell which requests used legacy models both as a client and via spans.