Skip to content

feat(dashboards): use theme tokens for dashboard widget previews#110963

Merged
obostjancic merged 2 commits intomasterfrom
ognjenbostjancic/tet-2100-update-dashboard-widget-previews
Mar 24, 2026
Merged

feat(dashboards): use theme tokens for dashboard widget previews#110963
obostjancic merged 2 commits intomasterfrom
ognjenbostjancic/tet-2100-update-dashboard-widget-previews

Conversation

@obostjancic
Copy link
Member

@obostjancic obostjancic commented Mar 18, 2026

Before

CleanShot 2026-03-18 at 09 02 31@2x CleanShot 2026-03-18 at 09 02 03@2x

After

CleanShot 2026-03-18 at 09 03 10@2x CleanShot 2026-03-18 at 09 02 44@2x

@linear-code
Copy link

linear-code bot commented Mar 18, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2026
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@obostjancic obostjancic marked this pull request as ready for review March 23, 2026 11:50
@obostjancic obostjancic requested a review from a team as a code owner March 23, 2026 11:50
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Table cell text uses border token, invisible in dark mode
    • Changed cellText from theme.tokens.border.secondary to theme.tokens.content.secondary to ensure visibility in dark mode.

Create PR

Or push these changes by commenting:

@cursor push 0e41fb66ec
Preview (0e41fb66ec)
diff --git a/static/app/views/dashboards/manage/gridPreview/chartPreviews/table.tsx b/static/app/views/dashboards/manage/gridPreview/chartPreviews/table.tsx
--- a/static/app/views/dashboards/manage/gridPreview/chartPreviews/table.tsx
+++ b/static/app/views/dashboards/manage/gridPreview/chartPreviews/table.tsx
@@ -4,7 +4,7 @@
   const theme = useTheme();
   const headerBg = theme.tokens.background.tertiary;
   const headerText = theme.tokens.content.secondary;
-  const cellText = theme.tokens.border.secondary;
+  const cellText = theme.tokens.content.secondary;
 
   return (
     <svg

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@obostjancic obostjancic merged commit 7e6f3a6 into master Mar 24, 2026
64 checks passed
@obostjancic obostjancic deleted the ognjenbostjancic/tet-2100-update-dashboard-widget-previews branch March 24, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants