Conversation
Fetch the saved dashboard details from the API when duplicating a prebuilt dashboard so that the user's saved filter values are preserved on the copy.
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
approved these changes
Mar 19, 2026
gggritso
deleted the
georgegritsouk/dain-1335-duplicating-a-pre-built-dashboard-doesnt-copy-over-the
branch
gggritso
added a commit
that referenced
this pull request
Mar 25, 2026
When duplicating a prebuilt dashboard, the clone was reconstructed from static config which has empty default values for page-level filters. The previous fix (#111017) copied the DashboardFilters object (globalFilter, release) but missed the top-level page filter fields (projects, environment, period, start, end, utc). Also fixes the manage/list view duplication path which never fetched the saved dashboard instance at all for prebuilt dashboards. Refs DAIN-1406 Co-Authored-By: Claude <noreply@anthropic.com>
gggritso
added a commit
that referenced
this pull request
Mar 27, 2026
…ds (#111534) When duplicating a prebuilt dashboard, the clone was reconstructed from static config which has empty default values for page-level filters. The previous fix (#111017) copied the `DashboardFilters` object (`globalFilter`, `release`) but missed the top-level page filter fields (`projects`, `environment`, `period`, `start`, `end`, `utc`). This also fixes the manage/list view duplication path (`useDuplicateDashboard`) which never fetched the saved dashboard instance at all for prebuilt dashboards, so all saved filters (including `globalFilter`) were lost in that code path. Both paths now use a shared `copySavedFilters` helper that copies all 7 filter fields from the saved instance onto the clone. Refs DAIN-1406 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When duplicating a prebuilt dashboard, the saved filter values (e.g. global filters configured by the user) were not being copied to the new dashboard. The duplication reconstructed the dashboard entirely from the static config, which has empty filter values.
Now,
useDuplicatePrebuiltDashboardfetches the saved dashboard from the detail endpoint to get the user's saved filters, then applies them to the duplicate. Widgets still come from the static config since they aren't stored for prebuilt dashboards.Fixes DAIN-1335