Skip to content

chore(occ-eap): Drop missing trace id log to debug#111096

Merged
thetruecpaul merged 1 commit intomasterfrom
cpaul/031926/missing-trace-info-debug
Mar 19, 2026
Merged

chore(occ-eap): Drop missing trace id log to debug#111096
thetruecpaul merged 1 commit intomasterfrom
cpaul/031926/missing-trace-info-debug

Conversation

@thetruecpaul
Copy link
Copy Markdown
Contributor

We've gotten the signal we need — 800k events every 5 minutes are missing their trace_id.

We've gotten the signal we need — 800k events every 5 minutes are missing their trace_id.
@thetruecpaul thetruecpaul requested review from a team and lobsterkatie March 19, 2026 16:06
@thetruecpaul thetruecpaul requested a review from a team as a code owner March 19, 2026 16:06
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 19, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

missing_fields = self._missing_required_item_fields(event_data)
if missing_fields:
logger.info(
logger.debug(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log level dropped to debug instead of info

Low Severity

The PR title states "Drop missing trace id to info" but the change sets the log level to logger.debug instead of logger.info. This drops the log level two steps (from infodebug) rather than the intended one step (e.g., from warninginfo). debug messages are typically filtered out in production, which may cause complete loss of observability for these 800k events every 5 minutes that are missing their trace_id.

Fix in Cursor Fix in Web

@thetruecpaul thetruecpaul changed the title chore(occ-eap): Drop missing trace id to info chore(occ-eap): Drop missing trace id log to debug Mar 19, 2026
@thetruecpaul thetruecpaul enabled auto-merge (squash) March 19, 2026 16:28
@thetruecpaul thetruecpaul merged commit 195ace1 into master Mar 19, 2026
82 checks passed
@thetruecpaul thetruecpaul deleted the cpaul/031926/missing-trace-info-debug branch March 19, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants