chore(occ-eap): Drop missing trace id log to debug#111096
Merged
thetruecpaul merged 1 commit intomasterfrom Mar 19, 2026
Merged
chore(occ-eap): Drop missing trace id log to debug#111096thetruecpaul merged 1 commit intomasterfrom
thetruecpaul merged 1 commit intomasterfrom
Conversation
We've gotten the signal we need — 800k events every 5 minutes are missing their trace_id.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| missing_fields = self._missing_required_item_fields(event_data) | ||
| if missing_fields: | ||
| logger.info( | ||
| logger.debug( |
Contributor
There was a problem hiding this comment.
Log level dropped to debug instead of info
Low Severity
The PR title states "Drop missing trace id to info" but the change sets the log level to logger.debug instead of logger.info. This drops the log level two steps (from info → debug) rather than the intended one step (e.g., from warning → info). debug messages are typically filtered out in production, which may cause complete loss of observability for these 800k events every 5 minutes that are missing their trace_id.
cvxluo
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We've gotten the signal we need — 800k events every 5 minutes are missing their trace_id.