Conversation
…ormance-vitals-standalone-cls-lcp, starfish-mobile-appstart, statistical-detectors-rca-spans-only) These flags are fully rolled out. Remove the flag registrations and simplify all gated code paths to use the graduated behavior directly rather than leaving behind trivially-true variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/description.tsx
Outdated
Show resolved
Hide resolved
- Fix aggregateSpanDiff tests to mock the spans endpoint (now the primary data source) instead of the old RCA endpoint - Fix webVitals detail panel test to use fcp (non-spans web vital) since lcp now uses the spans column order - Rename hasNewSpansUIFlag to hasInsightModules since the performance-spans-new-ui flag was removed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
static/app/views/insights/browser/webVitals/components/pageOverviewWebVitalsDetailPanel.tsx
Show resolved
Hide resolved
Since inp is always a spans web vital, the isInp branch was redundant with the isSpansWebVital check in the else branch. Collapse to a single GridEditable with the isSpansWebVital condition.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
static/app/components/events/eventStatisticalDetector/aggregateSpanDiff.tsx
Show resolved
Hide resolved
gggritso
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags are fully rolled out. Remove the flag registrations and simplify all gated code paths to use the graduated behavior directly rather than leaving behind trivially-true variables.