ref(cells): Update org provisioning code with cell terminology#111134
Merged
ref(cells): Update org provisioning code with cell terminology#111134
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
markstory
approved these changes
Mar 19, 2026
Comment on lines
+90
to
+91
| def _control_based_slug_change(self, organization_id: int, slug: str) -> None: | ||
| destination_cell_name = self._validate_or_default_cell(cell_name=None) |
Member
There was a problem hiding this comment.
👍 This initially looked wrong, but there are no callers that were using the region_name parameter.
Member
Author
There was a problem hiding this comment.
The orgid here is a snowflake ID so it's ok.. I think it's better to not pretend we were passing a region/cell when we never do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.