Skip to content

ref(cells): Update org provisioning code with cell terminology#111134

Merged
lynnagara merged 7 commits intomasterfrom
org-provisioning
Mar 19, 2026
Merged

ref(cells): Update org provisioning code with cell terminology#111134
lynnagara merged 7 commits intomasterfrom
org-provisioning

Conversation

@lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team March 19, 2026 19:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 19, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment on lines +90 to +91
def _control_based_slug_change(self, organization_id: int, slug: str) -> None:
destination_cell_name = self._validate_or_default_cell(cell_name=None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This initially looked wrong, but there are no callers that were using the region_name parameter.

Copy link
Member Author

@lynnagara lynnagara Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orgid here is a snowflake ID so it's ok.. I think it's better to not pretend we were passing a region/cell when we never do

@lynnagara lynnagara merged commit 8507585 into master Mar 19, 2026
105 checks passed
@lynnagara lynnagara deleted the org-provisioning branch March 19, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants