Conversation
Unblock import of similarly-named component
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
static/app/views/dashboards/widgetCard/widgetCardChartContainer.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
@edwardgou-sentry heads-up, I had to change the dashboard error reporting since I ditched the error callback, but I think the render path is the same, so the error reporting will work like it did before. Let me know if not, though! |
edwardgou-sentry
approved these changes
Mar 23, 2026
gggritso
deleted the
georgegritsouk/dain-1375-replace-red-banner-widget-error-state
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DAIN-1375. Current dashboard widgets have a very horrible red banner for error states, and an even more horrible error boundary:
e.g.,
This PR replaces both of them with
Widget.WidgetErrorwhich is the standard way to handle this.e.g.,
I had to alias
WidgettoTWidgetto allow importing theWidgetcomponent in a few places, but overall, this PR just replaces a bunch of custom error handling done through render props with a simple conditional that usesWidgetErrorto render errors.