Conversation
JonasBa
commented
Mar 19, 2026
| } | ||
|
|
||
| :hover [data-reorderable-handle-slot] { | ||
| :hover [data-reorderable-handle-slot], |
Member
Author
There was a problem hiding this comment.
Small fix to the visibility of the handle
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
natemoo-re
reviewed
Mar 19, 2026
Member
natemoo-re
left a comment
There was a problem hiding this comment.
Unfortunately doesn't seem to stop the page scroll
https://github.com/user-attachments/assets/cd73eb4d-3a39-4d12-893f-77453e256454
Replace the manual ref + capture-phase keydown listener with useScrollLock(document.body) to prevent page scroll during keyboard-driven drag-and-drop in the secondary navigation reorderable list. The previous implementation was also broken: the useEffect checked isKeyboardDraggingRef.current at mount time (always false), so the arrow-key scroll prevention listener was never actually registered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
natemoo-re
approved these changes
Mar 19, 2026
Member
natemoo-re
left a comment
There was a problem hiding this comment.
Nice, it's working with the scroll lock!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes an issue with secondary navigation where page scroll was triggered during keyboard navigation