feat(ACI): Make rule stats and group history endpoints backwards compatible#111159
Merged
feat(ACI): Make rule stats and group history endpoints backwards compatible#111159
Conversation
kcons
approved these changes
Mar 19, 2026
Member
kcons
left a comment
There was a problem hiding this comment.
LG, haven't dug too far into the test coverage though.
I don't think it'd be crazy to use a single query that still supports Rules; if we're not passing an ID, it's a no-op, and it's easy enough to adjust the query once we don't want to mention Rules ever again.
kcons
reviewed
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
kcons
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Redo of #110282 to make the rule stats and group history endpoints backwards compatible by being flexible enough to handle either a
Ruleor aWorkflow. The previous PR was reverted because I incorrectly assumedRuleobjects were usingRuleFireHistory, but it is correct to continue to combine those results withWorkflowFireHistoryfor now.For both methods the basic logic is as follows:
AlertRuleWorkflowand fetch combined results. If the workflow was single written, fetchWorkflowFireHistoryresults only.AlertRuleWorkflowand fetch combined results. If the rule for some reason doesn't have a workflow, fetchRuleFireHistoryresults only (this maintains the existing behavior).