ref(api): Add snuba version of stream group serializer to support multi env#11120
Merged
Conversation
macqueen
force-pushed
the
ref-stream-group-serializer-snuba
branch
from
35caec2 to
6073de2
Compare
wedamija
reviewed
Dec 20, 2018
Member
There was a problem hiding this comment.
Why do we set all stats to 0 when no envs are provided? In the other serializer, we only do this if an invalid environment was passed.
Member
There was a problem hiding this comment.
Nice, wasn't sure if intentional or not
macqueen
force-pushed
the
ref-stream-group-serializer-snuba
branch
from
6073de2 to
8acabba
Compare
wedamija
approved these changes
Dec 21, 2018
macqueen
force-pushed
the
ref-stream-group-serializer-snuba
branch
2 times, most recently
from
ee082ba to
75e8257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.