Skip to content

ref(cells): remove support for region_name in ByCellName resolver#111221

Merged
lynnagara merged 2 commits intomasterfrom
by-cell-name-resolver
Mar 23, 2026
Merged

ref(cells): remove support for region_name in ByCellName resolver#111221
lynnagara merged 2 commits intomasterfrom
by-cell-name-resolver

Conversation

@lynnagara
Copy link
Member

all cell rpc methods that use the ByCellName resolver have been migrated to cell_name. We can drop support for region_name now.

all cell rpc methods that use the ByCellName resolver have been
migrated to cell_name. We can drop support for region_name now.
@lynnagara lynnagara requested a review from a team March 20, 2026 17:53
@lynnagara lynnagara requested a review from a team as a code owner March 20, 2026 17:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 20, 2026
@github-actions
Copy link
Contributor

Backend Test Failures

Failures on 3cb8478 in this run:

tests/sentry/hybridcloud/test_cell.py::CellResolutionTest::test_by_cell_namelog
tests/sentry/hybridcloud/test_cell.py:35: in test_by_cell_name
    assert resolver.resolve({"region_name": self.target_cell.name}) == self.target_cell
src/sentry/hybridcloud/rpc/resolvers.py:47: in resolve
    cell_name = arguments[self.parameter_name]
E   KeyError: 'cell_name'

@lynnagara lynnagara merged commit 22cd75c into master Mar 23, 2026
105 checks passed
@lynnagara lynnagara deleted the by-cell-name-resolver branch March 23, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants