Draft
Conversation
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
54d6731 to
3844b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another
ref(⚡️)speedup—this time removingstylelintentirelyWe've gone back and forth on having
stylelintin the codebase. It was removed in June 2024 (biome added) and added back in November 2024 (biome removed). In the 68k+ commits between then and now, stylelint has detected zero meaningful violations.pre-commitrunsstylelintwith--quietwhich suppresses warnings entirelystylelintCSS-in-JS support isn't great—the maintenance cost here has been us trying to get the two to play nicelystylelint-disablecomments were all false-positives, not real issues@sentry/scrapslint rules enforce semantic token usage and general design system adherence across JS and CSS-in-JS which is a better enforcement mechanismResults
Ran
hyperfineagainst a few different configurations ofpnpm lintto understand the performance win here.pnpm run lint:css(stylelint only)pnpm run linton master (eslint + stylelint)pnpm run linton branch (eslint only)stylelintremoval makespnpm run lint1.57x faster, saving ~52 seconds.