Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| content | ||
| )} | ||
| </FullViewport> | ||
| </Layout.Page> |
There was a problem hiding this comment.
Footer hiding CSS selector broken by nesting change
Medium Severity
FullViewport uses a ~ footer CSS sibling selector to hide the page footer, and its own comment explicitly states "The footer component is a sibling of this div." Wrapping FullViewport inside Layout.Page means it's no longer a DOM sibling of footer — so the selector no longer matches and the footer won't be hidden. The trace view handles this correctly by placing ~ footer { display: none } on the LayoutPageWithHiddenFooter (a styled Layout.Page), but the replay detail view doesn't get the same treatment.
…oter hiding
The flamegraph views use a CSS sibling selector to hide the footer
(~ footer { display: none }). When Layout.Page was added to the parent
provider components, it broke this selector because FlamegraphContainer
was no longer a sibling of the footer element.
This change moves Layout.Page from the provider components to the
individual flamegraph child routes, using a styled LayoutPageWithHiddenFooter
component that applies the footer hiding CSS at the correct level.
Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
3 participants
Add missing Layout.Page from explore views which fixes the pageframe background and layout when the pageframe flag is enabled