Skip to content

chore(flags): Remove organizations:sdk-crash-detection feature flag#111267

Closed
wedamija wants to merge 1 commit into
masterfrom
danf/remove-sdk-crash-detection-flag
Closed

chore(flags): Remove organizations:sdk-crash-detection feature flag#111267
wedamija wants to merge 1 commit into
masterfrom
danf/remove-sdk-crash-detection-flag

Conversation

@wedamija
Copy link
Copy Markdown
Member

Summary

  • Remove the organizations:sdk-crash-detection feature flag gate from post_process.py
  • Remove the flag registration from temporary.py
  • Remove the test for disabled-feature behavior (no longer applicable)

Why

SDK crash detection is controlled by an option-backed rollout handler in getsentry with three rollout options (la-rollout, ea-rollout, ga-rollout). Currently:

  • US: ga-rollout: 1.0 (fully enabled)
  • s4s2: ga-rollout: 1.0 (fully enabled)
  • DE: ga-rollout: 0.0 (disabled — appears to be an oversight)

Rather than enabling DE separately, we're graduating the flag entirely so SDK crash detection runs everywhere. The option-backed rollout handler and LA org list in getsentry will be cleaned up in a follow-up PR after this deploys.

Merge order

  1. This PR (sentry) — remove the flag check and registration
  2. getsentry PR — remove ROLLOUT_FEATURES entry, SDK_CRASH_DETECTION_LA_ORGS
  3. sentry-options-automator PR — remove regional option values

cc @getsentry/ingest @getsentry/issue-detection-backend

🤖 Generated with Claude Code

@wedamija wedamija requested a review from a team as a code owner March 21, 2026 00:10
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 21, 2026
@wedamija wedamija requested a review from a team March 21, 2026 00:11
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR seems to have turned it off intentionally in de: https://github.com/getsentry/sentry-options-automator/pull/6243

there's also a reference to the flag here:

Furthermore, you can change the project to store the crash events and the sample rate per SDK with the options ``issues.sdk_crash_detection.cocoa.project_id`` and ``issues.sdk_crash_detection.cocoa.sample_rate``.

@wedamija
Copy link
Copy Markdown
Member Author

this PR seems to have turned it off intentionally in de: getsentry/sentry-options-automator#6243

there's also a reference to the flag here:

Furthermore, you can change the project to store the crash events and the sample rate per SDK with the options ``issues.sdk_crash_detection.cocoa.project_id`` and ``issues.sdk_crash_detection.cocoa.sample_rate``.

Ahh, damn... It'd be nice to migrate this to use options automator instead

SDK crash detection is fully rolled out in US and s4s2 (ga-rollout: 1.0)
but was never enabled in DE (ga-rollout: 0.0), which appears to be an
oversight. Rather than enabling it region-by-region, graduate the flag
entirely so all regions get SDK crash detection.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wedamija added a commit that referenced this pull request Apr 1, 2026
This flag is still in use, but using an old deprecated rollout handler that I'd like to remove. Setting this to flagpole allows us to still fall back to the old handler until we roll out the options in `sentry-options-automator` and remove the old handler.

Relatd to #111267, which I'll likely close
wedamija added a commit that referenced this pull request Apr 2, 2026
…112069)

This flag is still in use, but using an old deprecated rollout handler
that I'd like to remove. Setting this to flagpole allows us to still
fall back to the old handler until we roll out the options in
`sentry-options-automator` and remove the old handler.

Related to #111267, which I'll
likely close
@wedamija wedamija closed this Apr 2, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants