Skip to content

ref(nav) implement new help menu#111269

Merged
JonasBa merged 2 commits intomasterfrom
jb/rev/nav-page-frame
Mar 23, 2026
Merged

ref(nav) implement new help menu#111269
JonasBa merged 2 commits intomasterfrom
jb/rev/nav-page-frame

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 21, 2026

Implements the new menu for when page frame is enabled and hides the footer.

Before After
CleanShot 2026-03-20 at 17 27 20@2x CleanShot 2026-03-20 at 17 27 52@2x

@JonasBa JonasBa requested a review from a team as a code owner March 21, 2026 00:29
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 21, 2026
@JonasBa JonasBa changed the title ref(nav) implement new menu ref(nav) implement new help menu Mar 21, 2026
const secondaryNavigation = useContext(SecondaryNavigationContext);
const hasPageFrame = useHasPageFrameFeature();

if (hasPageFrame) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR because the footer items get moved to the new help menu

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement! Nice work

@JonasBa
Copy link
Member Author

JonasBa commented Mar 23, 2026

Huge improvement! Nice work

Thank you! 🙏🏼

@JonasBa JonasBa merged commit 12c78a9 into master Mar 23, 2026
72 checks passed
@JonasBa JonasBa deleted the jb/rev/nav-page-frame branch March 23, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants