Skip to content

test(regression): Add failing test for stale current_release_version causing false regression#111309

Draft
mrduncan wants to merge 1 commit intomasterfrom
mrduncan/semver-release
Draft

test(regression): Add failing test for stale current_release_version causing false regression#111309
mrduncan wants to merge 1 commit intomasterfrom
mrduncan/semver-release

Conversation

@mrduncan
Copy link
Copy Markdown
Member

When an integration resolves an issue "in next release" while follows_semver is False, the current_release_version is set via date ordering. If follows_semver later flips to True, has_resolution compares against the stale current_release_version instead of the resolution's release, causing a false regression on older semver versions.

…causing false regression

When an integration resolves an issue "in next release" while follows_semver
is False, the current_release_version is set via date ordering. If
follows_semver later flips to True, has_resolution compares against the stale
current_release_version instead of the resolution's release, causing a false
regression on older semver versions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on beb00d1 in this run:

tests/sentry/models/test_groupresolution.py::GroupResolutionTest::test_stale_current_release_version_with_semver_fliplog
tests/sentry/models/test_groupresolution.py:241: in test_stale_current_release_version_with_semver_flip
    assert GroupResolution.has_resolution(self.group, event_release)
E   AssertionError: assert False
E    +  where False = <bound method GroupResolution.has_resolution of <class 'sentry.models.groupresolution.GroupResolution'>>(<Group at 0x7fb2325bde50: id=21, project_id=4557842896322560>, <Release at 0x7fb23204cd60: id=107, organization_id=4557842896322560, version='foo_package@1.4'>)
E    +    where <bound method GroupResolution.has_resolution of <class 'sentry.models.groupresolution.GroupResolution'>> = GroupResolution.has_resolution
E    +    and   <Group at 0x7fb2325bde50: id=21, project_id=4557842896322560> = <tests.sentry.models.test_groupresolution.GroupResolutionTest testMethod=test_stale_current_release_version_with_semver_flip>.group

@getsantry
Copy link
Copy Markdown
Contributor

getsantry bot commented Apr 14, 2026

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant