fix(ui): Preserve Seer paths in URL normalization#111317
Merged
Conversation
Normalization treated the first segment after /settings/ as the org slug, which dropped /seer/ from org Seer settings and broke tab links. Exclude seer (and tighten stats matching) in normalizeUrl patterns, pass the normalized href from Seer settings tabs, and add regression tests. Co-Authored-By: Cursor <cursor@cursor.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
Member
|
Looks related to #111279 |
ryan953
approved these changes
Mar 23, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Backend URL patterns not updated to preserve seer paths
- Updated the backend customer-domain settings path regexes to preserve Seer routes and added a regression test for
/settings/seer/paths.
- Updated the backend customer-domain settings path regexes to preserve Seer routes and added a regression test for
Or push these changes by commenting:
@cursor push cd2cbeb33a
Preview (cd2cbeb33a)
diff --git a/src/sentry/organizations/absolute_url.py b/src/sentry/organizations/absolute_url.py
--- a/src/sentry/organizations/absolute_url.py
+++ b/src/sentry/organizations/absolute_url.py
@@ -12,13 +12,13 @@
(re.compile(r"\/?organizations\/(?!new)[^/]+\/(.*)"), r"/\1"),
# For /settings/:orgId/ -> /settings/organization/
(
- re.compile(r"\/settings\/(?!account\/|!billing\/|projects\/|teams)[^/]+\/?$"),
+ re.compile(r"\/settings\/(?!account\/|!billing\/|projects\/|teams|seer\/)[^/]+\/?$"),
"/settings/organization/",
),
# Move /settings/:orgId/:section -> /settings/:section
# but not /settings/organization or /settings/projects which is a new URL
(
- re.compile(r"^\/?settings\/(?!account\/|billing\/|projects\/|teams)[^/]+\/(.*)"),
+ re.compile(r"^\/?settings\/(?!account\/|billing\/|projects\/|teams|seer\/)[^/]+\/(.*)"),
r"/settings/\1",
),
(re.compile(r"^\/?join-request\/[^/]+\/?.*"), r"/join-request/"),
diff --git a/tests/sentry/organizations/test_absolute_url.py b/tests/sentry/organizations/test_absolute_url.py
--- a/tests/sentry/organizations/test_absolute_url.py
+++ b/tests/sentry/organizations/test_absolute_url.py
@@ -64,6 +64,8 @@
"/settings/projects/getting-started/abc123/",
),
("/settings/teams/peeps/", "/settings/teams/peeps/"),
+ ("/settings/seer/", "/settings/seer/"),
+ ("/settings/seer/repos/", "/settings/seer/repos/"),
# Prevent routes should remain as-is
("/prevent/", "/prevent/"),
("/prevent/tokens/", "/prevent/tokens/"),This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| // but not /settings/organization or /settings/projects which is a new URL | ||
| [ | ||
| /^\/?settings\/(?!account\/|billing\/|projects\/|teams\/|stats\/)[^/]+\/(.*)/, | ||
| /^\/?settings\/(?!account\/|billing\/|projects\/|teams\/|stats\/|seer\/)[^/]+\/(.*)/, |
Contributor
There was a problem hiding this comment.
Backend URL patterns not updated to preserve seer paths
Medium Severity
Line 5 of this file says "If you change this also update the patterns in sentry.api.utils." The server-side companion patterns in src/sentry/organizations/absolute_url.py (_path_patterns) were not updated with the seer\/ exclusion. If the backend normalizes an already-normalized path like /settings/seer/repos/ via customer_domain_path(), it will treat seer as an org slug and produce /settings/repos/, breaking server-generated Seer settings URLs (e.g. in emails or redirects).
scttcper
added a commit
that referenced
this pull request
Mar 23, 2026
scttcper
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalization treated the first segment after /settings/ as the org slug, which dropped /seer/ from org Seer settings and broke tab links. Exclude seer