feat(preprod): Show original filename tooltip on renamed snapshots#111325
Merged
NicoHinderling merged 3 commits intomasterfrom Mar 23, 2026
Merged
feat(preprod): Show original filename tooltip on renamed snapshots#111325NicoHinderling merged 3 commits intomasterfrom
NicoHinderling merged 3 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
rbro112
reviewed
Mar 23, 2026
| <InlineCode>{currentImage.image_file_name}</InlineCode> | ||
| </span> | ||
| } | ||
| maxWidth={2000} |
Member
There was a problem hiding this comment.
What's the 2000 here? Seems oddly specific
Contributor
Author
There was a problem hiding this comment.
it's the max width, i just don't want the tooltip wrap unless it really needs to. really any big number here i guess lol
rbro112
reviewed
Mar 23, 2026
static/app/views/preprod/snapshots/main/snapshotMainContent.tsx
Outdated
Show resolved
Hide resolved
rbro112
reviewed
Mar 23, 2026
NicoHinderling
force-pushed
the
nicolashinderling/feat/snapshot-renamed-tooltip
branch
from
f980cce to
9857c17
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
NicoHinderling
commented
Mar 23, 2026
| <Layout.Title> | ||
| {/* TODO: Replace with app-id/version when available */} | ||
| <Heading as="h2">{t('Snapshots')}</Heading> | ||
| {t('Snapshots')} |
Contributor
Author
There was a problem hiding this comment.
technically unrelated to this change, but noticed this simple console error I wanted to fix too
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
rbro112
reviewed
Mar 23, 2026
rbro112
approved these changes
Mar 23, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Removed empty filename guard renders empty InlineCode element
- Added a truthiness guard in
ImageFileNameso empty filenames now render nothing instead of an emptyInlineCodebadge.
- Added a truthiness guard in
Or push these changes by commenting:
@cursor push bb23dfbf76
Preview (bb23dfbf76)
diff --git a/static/app/views/preprod/snapshots/main/snapshotMainContent.tsx b/static/app/views/preprod/snapshots/main/snapshotMainContent.tsx
--- a/static/app/views/preprod/snapshots/main/snapshotMainContent.tsx
+++ b/static/app/views/preprod/snapshots/main/snapshotMainContent.tsx
@@ -286,6 +286,10 @@
fileName: string;
previousFileName?: string;
}) {
+ if (!fileName) {
+ return null;
+ }
+
if (previousFileName) {
return (
<TooltipThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Add previous_image_file_name to SnapshotImage type and display a tooltip on renamed image filenames showing the rename transition (old name → new name). Renamed filenames use the accent InlineCode variant as a visual hint that they are hoverable. Refs EME-961 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed and renamed types shared one union variant which prevented TypeScript from narrowing the discriminant after type guards.
NicoHinderling
force-pushed
the
nicolashinderling/feat/snapshot-renamed-tooltip
branch
from
9857c17 to
b1f224b
Compare
NicoHinderling
deleted the
nicolashinderling/feat/snapshot-renamed-tooltip
branch
NicoHinderling
added a commit
that referenced
this pull request
Mar 23, 2026
…#111332) ## Summary Follow-up to #111325 — refactors renamed snapshot items to use `SnapshotDiffPair` instead of a flat `SnapshotImageResponse` with a `previous_image_file_name` field. A rename is conceptually a diff from old image → new image, so the pair structure naturally models this: - `base_image` = old filename (looked up by `previous_image_file_name`) - `head_image` = new filename - `diff` / `diff_image_key` remain `None` (no visual diff for renames) ### Changes - **`SnapshotImageResponse`**: Remove `previous_image_file_name` field (no longer needed in API response) - **`SnapshotDetailsApiResponse`**: Change `renamed` from `list[SnapshotImageResponse]` to `list[SnapshotDiffPair]` - **`CategorizedComparison`**: Same type change for `renamed` - **`categorize_comparison_images`**: Build `SnapshotDiffPair` for renamed items by looking up base image by old filename from `base_images_by_file_name` Note: `previous_image_file_name` is kept on `ComparisonImageResult` in `manifest.py` — that's internal transport from tasks → categorizer, not part of the API response. ## Test plan - [ ] Existing backend snapshot tests pass - [ ] Frontend PR (#111325) updated to consume renamed as `SnapshotDiffPair[]` - [ ] Manual: renamed items show tooltip with old → new filename --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the previous filename when hovering over a renamed snapshot image's filename.
When images are renamed between builds, the UI now shows a tooltip with the rename
transition (
old_name → new_name) on hover. Renamed filenames use the accentInlineCodevariant (purple tint) as a visual hint that additional info is available.Changes:
previous_image_file_nameto theSnapshotImageTypeScript interfaceTooltipshowing the before → after namesInlineCodeinside the tooltip for consistent stylingCloses EME-961
Regular snapshot title UI:
Renamed snapshot title:
tooltip if you hover the title:
