Conversation
… member projects When a user has no member projects and the URL contains -1 (All Projects sentinel), the filter was incorrectly displaying a project count or enumerated list instead of 'All Projects'. The issue occurred because: 1. URL parameter -1 gets expanded to all individual project IDs 2. The trigger's logic checked if both member AND non-member projects were selected 3. When memberProjects.length === 0, this check failed Fix: Check if value contains all project IDs regardless of member/non-member split. Added tests to cover the edge case of users with no member projects. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
github-actions
bot
added
the
Scope: Frontend
natemoo-re
approved these changes
Mar 23, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Confirming this fixes the issue for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user has no member projects (their team doesn't own/belong to any projects) and the URL contains
project=-1(All Projects sentinel), the project filter trigger was incorrectly displaying a project count or enumerated list instead of the "All Projects" label.Root Cause
-1(ALL_ACCESS_PROJECTS) gets expanded internally to all individual project IDsisAllProjectsSelectedlogic was checking if bothisMyProjectsSelectedANDisNonMemberProjectsSelectedwere trueisMyProjectsSelectedrequiresmemberProjects.length > 0to be trueSolution
Updated the logic in
projectPageFilterTrigger.tsxto directly check if thevaluearray contains all project IDs, regardless of the member/non-member split. This correctly handles the edge case.Changes
ProjectPageFilterTriggerto use acontainsAllProjectscheck that verifies all project IDs are present in the value arrayisNonMemberProjectsSelectedvariableTesting
projectPageFilter.spec.tsx:Fixes the issue described in the Slack thread where the UI was showing a count instead of "All Projects" for users without member projects.
Slack Thread