feat(project-filters): Simplify All/My Projects toggle#111331
Draft
feat(project-filters): Simplify All/My Projects toggle#111331
Conversation
Implement UX improvement suggested by @TkDodo to make 'All Projects' and 'My Projects' work as a simple toggle between two mutually exclusive states. Previous behavior (complex): - Clicking 'All Projects' when selected would deselect - Clicking 'My Projects' when 'All Projects' was active would show only non-member projects - Multiple clicks were needed to switch between states New behavior (simple toggle): - Clicking 'All Projects' always selects all projects - Clicking 'My Projects' always selects member projects - Single click to toggle between the two states This is technically less precise (can't have partial selections via these shortcuts) but provides much better UX with clearer, more predictable behavior. Updated tests to reflect new toggle behavior and removed unused helper function. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement UX improvement suggested by @TkDodo to make 'All Projects' and 'My Projects' work as a simple toggle between two mutually exclusive states.
Previous behavior (complex):
New behavior (simple toggle):
This is technically less precise (can't have partial selections via these shortcuts) but provides much better UX with clearer, more predictable behavior.
Updated tests to reflect new toggle behavior and removed unused helper function.