chore(ACI): Add warning banner to old alerts by ceorourke · Pull Request #111344 · getsentry/sentry

ceorourke · 2026-03-23T20:37:41Z

Add a warning banner to the old issue alerts pages if the workflow engine serializers flag is enabled letting users know there could be parts of the alert we cannot render in the old UI if they've created or edited alerts or monitors in the new UI. For issue alerts this is filtered down to alerts where there are unsupported conditions or the new alert uses multiple if/then conditions which can't be shown in the old UI.

github-actions · 2026-03-23T20:37:57Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

ceorourke · 2026-03-23T20:38:53Z

static/app/views/alerts/rules/APIUsageWarningBanner.tsx

+export function WorkflowEngineAlert() {
+  const organization = useOrganization();
+
+  if (!organization.features.includes('workflow-engine-rule-serializers')) {


We've been releasing individual backwards compatible endpoints behind different flags but this is the main control one

ceorourke · 2026-03-23T20:39:31Z

static/app/views/alerts/rules/workflowEngineAlert.tsx

+    <Alert.Container>
+      <Alert variant="warning">
+        {tct(
+          "Some aspects of alerts may not be visible if you've used the [link:new monitors and alerts UI].",


I'm open to wording changes here - usage of the new API could also result in this but I didn't necessarily want to push users to it in this view.

🤔 we can probably assume they don't have access to the new UI here, otherwise we should be redirecting them to it.

Maybe we can just say "The legacy alerts UI does not support all features. If you've modified the alert using the new API, those settings will be used during evaluation but aren't fully reflected in the UI." -- or something along those lines, basically saying "hey - we are evaluating this the way you expected, but you're using an experimental API so it caused a mismatch."

ceorourke · 2026-03-23T20:40:06Z

src/sentry/features/temporary.py

    manager.add("organizations:workflow-engine-redirect-opt-out", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
    # Use workflow engine serializers to return data for old rule / incident endpoints
-    manager.add("organizations:workflow-engine-rule-serializers", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    manager.add("organizations:workflow-engine-rule-serializers", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)


I know we're supposed to decouple fe and be changes but given this flag isn't widely enabled I think it's ok.

saponifi3d · 2026-03-23T20:45:26Z

static/app/views/alerts/rules/metric/details/body.tsx

      )}
      <Layout.Body>
        <Layout.Main>
+          <WorkflowEngineAlert />


can we check the api results for a flag to see if we need to render the warning?

I have unsupported conditions in the errors results of the response but there are other situations (like if they used an if/then block) that would take more effort to identify.

Ok kinda went down a rabbithole here, I think for now what I'm going to do is add the if/then block condition to the errors response and conditionally render the banner if any of the known error cases are hit for issue alerts. For metric alerts we might have more proverbial fish to fry, but this is at least a starting point that covers the majority of cases in an already edge case problem set.

static/app/views/alerts/rules/workflowEngineAlert.tsx

saponifi3d · 2026-03-23T20:47:58Z

static/app/views/alerts/rules/issue/details/ruleDetails.tsx

      </Layout.Header>
      <Layout.Body>
        <Layout.Main>
+          <WorkflowEngineAlert />


same question about being able to read the rule value to determine if we need to render the banner or not.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Feature flag default=True enables serializers for all orgs
- Removed the default=True override from organizations:workflow-engine-rule-serializers so orgs only use workflow serializer paths when explicitly enabled.

Or push these changes by commenting:

@cursor push 442257f1f4

Preview (442257f1f4)

diff --git a/src/sentry/features/temporary.py b/src/sentry/features/temporary.py
--- a/src/sentry/features/temporary.py
+++ b/src/sentry/features/temporary.py
@@ -418,7 +418,7 @@
     # Disable redirects from alert rules to the new workflow_engine UI
     manager.add("organizations:workflow-engine-redirect-opt-out", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True, default=True)
     # Use workflow engine serializers to return data for old rule / incident endpoints
-    manager.add("organizations:workflow-engine-rule-serializers", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True, default=True)
+    manager.add("organizations:workflow-engine-rule-serializers", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Use workflow engine exclusively for ProjectRulesEndpoint.get results.
     # See src/sentry/workflow_engine/docs/legacy_backport.md for context.
     manager.add("organizations:workflow-engine-projectrulesendpoint-get", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

src/sentry/features/temporary.py

…workflow (#111378) If multiple if/then blocks are used in a workflow we're only able to render one of them in the legacy issue alerts UI. This PR adds an item to the `errors` response so that we can render a warning on the front end. See #111344 which will be updated to read this error.

saponifi3d

lgtm, thanks for updating!

github-actions · 2026-03-25T21:48:32Z

Backend Test Failures

Failures on 35a8556 in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registered — log

tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.workflow_engine.tasks.cleanup
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

static/app/views/alerts/rules/issue/details/ruleDetails.tsx

github-actions · 2026-03-25T22:22:35Z

Backend Test Failures

Failures on 673c700 in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registered — log

tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.workflow_engine.tasks.cleanup
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

ceorourke requested a review from a team as a code owner March 23, 2026 20:37

github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 23, 2026

vercel bot deployed to Preview March 23, 2026 20:38 View deployment

ceorourke commented Mar 23, 2026

View reviewed changes

saponifi3d reviewed Mar 23, 2026

View reviewed changes

vercel bot deployed to Preview March 23, 2026 20:53 View deployment

vercel bot deployed to Preview March 23, 2026 21:07 View deployment

vercel bot deployed to Preview March 23, 2026 22:59 View deployment

ceorourke mentioned this pull request Mar 23, 2026

chore(ACI): Add error to response if multiple if/then blocks used in workflow #111378

Merged

ceorourke force-pushed the ceorourke/warning-rule-banner branch from 33d37a6 to b9fad53 Compare March 25, 2026 16:59

cursor bot reviewed Mar 25, 2026

View reviewed changes

src/sentry/features/temporary.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview March 25, 2026 17:09 View deployment

getsentry deleted a comment from github-actions bot Mar 25, 2026

vercel bot deployed to Preview March 25, 2026 18:48 View deployment

getsentry deleted a comment from github-actions bot Mar 25, 2026

ceorourke requested a review from saponifi3d March 25, 2026 21:28

ceorourke force-pushed the ceorourke/warning-rule-banner branch from e206341 to 90429a7 Compare March 25, 2026 21:29

vercel bot deployed to Preview March 25, 2026 21:31 View deployment

saponifi3d approved these changes Mar 25, 2026

View reviewed changes

ceorourke force-pushed the ceorourke/warning-rule-banner branch from 90429a7 to 292ea5d Compare March 25, 2026 22:02

sentry bot reviewed Mar 25, 2026

View reviewed changes

static/app/views/alerts/rules/issue/details/ruleDetails.tsx Show resolved Hide resolved

vercel bot deployed to Preview March 25, 2026 22:05 View deployment

chore(ACI): Add warning banner to old alerts

83de013

ceorourke added 5 commits March 25, 2026 16:05

wording

d90bb7c

rename

8b7b5c8

filter to specific errors

992f0d3

oops that wasn't meant to be there

5abb46c

update to include new error

c99770e

ceorourke force-pushed the ceorourke/warning-rule-banner branch from 292ea5d to c99770e Compare March 25, 2026 23:05

vercel bot deployed to Preview March 25, 2026 23:08 View deployment

ceorourke merged commit 4cf2eaf into master Mar 26, 2026
97 of 99 checks passed

ceorourke deleted the ceorourke/warning-rule-banner branch March 26, 2026 17:20

Uh oh!

Conversation

ceorourke commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

ceorourke Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

ceorourke Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

saponifi3d Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

ceorourke Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

saponifi3d Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

ceorourke Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

ceorourke Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saponifi3d Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saponifi3d left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2026

Backend Test Failures

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Backend Test Failures

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ceorourke commented Mar 23, 2026 •

edited

Loading

ceorourke Mar 23, 2026 •

edited

Loading

cursor bot left a comment •

edited

Loading