ref(grouping): Simplify parameterizer code#111345
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-more-parameterizer-refactors
branch
from
25abad3 to
9bd39e2
Compare
lobsterkatie
force-pushed
the
kmclb-more-parameterizer-refactors
branch
from
9bd39e2 to
f8f5f24
Compare
nora-shap
approved these changes
Mar 31, 2026
Member
nora-shap
left a comment
nora-shap
left a comment
There was a problem hiding this comment.
as always, I appreciate your docstrings/comments 🚀
dashed
pushed a commit
that referenced
this pull request
Apr 1, 2026
This is handful of refactors to the parameterization code, to make it a bit simpler and more testable. - Allow `ParameterizationRegex` objects to be passed directly to parameterizer during initialization rather than always using the default set. (This should make it easier to test, so we don't have to do a bunch of mocking.) If none are passed, the default set will still be used. - Create the final regex directly in `__init__` rather than in a separate method. - When deciding if the experimental parameterizer is actually experimental, look at the regexes themselves rather than at the regex maps. - When deciding whether to skip testing the experimental parameterizer, look directly at it rather than comparing the regex maps. - Use `lastgroup` to get matched key/original value directly rather than iterating over `groupdict`. - Remove the now-unused regex maps. - Rename a number of things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is handful of refactors to the parameterization code, to make it a bit simpler and more testable.
Allow
ParameterizationRegexobjects to be passed directly to parameterizer during initialization rather than always using the default set. (This should make it easier to test, so we don't have to do a bunch of mocking.) If none are passed, the default set will still be used.Create the final regex directly in
__init__rather than in a separate method.When deciding if the experimental parameterizer is actually experimental, look at the regexes themselves rather than at the regex maps.
When deciding whether to skip testing the experimental parameterizer, look directly at it rather than comparing the regex maps.
Use
lastgroupto get matched key/original value directly rather than iterating overgroupdict.Remove the now-unused regex maps.
Rename a number of things.