fix(scraps): omit type from SVGIconProps#111353
Merged
natemoo-re merged 4 commits intomasterfrom Mar 24, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
natemoo-re
force-pushed
the
scraps/fix/svg-type
branch
from
1ed8486 to
e2762fd
Compare
JonasBa
approved these changes
Mar 24, 2026
Member
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
Nice, iirc we have a few more of these, but one at a time 🫡✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaydgoss hit an interesting type issue in #111160
The gist is
SVGIconPropsextendsReact.SVGAttributes<SVGSVGElement>which includestype: string, but that's not actually valid for the root<svg>of our icon component.By omitting
typefromSVGIconProps,IconGraphPropsno longer narrows thetype: stringprop, sotypebecomes a new optional prop. The eliminates the variance conflict, soComponentType<IconGraph>should be directly assignable toSVGIconProps.