ref(scm): Initialize in '__init__' instead of '__new__'#111389
Merged
ref(scm): Initialize in '__init__' instead of '__new__'#111389
Conversation
github-actions
bot
added
the
Scope: Backend
cmanallen
approved these changes
Mar 24, 2026
Member
cmanallen
left a comment
cmanallen
left a comment
There was a problem hiding this comment.
Easy enough! Nice work figuring this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colton, I was double-checking why you said that initializing the SCM Facade in its
__init__method did not work, which I felt could be hiding something more serious.My conclusion is that you observed that behavior on an intermediate version of #111113, when
_facade_type_for_provider_classwas returning a subclass ofFacade. You then fixed the main issue by making it return a subclass ofcls, but did not realize this allowed moving the initialization back to__init__.I did that, and added a test.
Reference:
object.__new__andobject.__init__.