ref(nav) promote search to primary nav#111430
Conversation
github-actions
bot
added
the
Scope: Frontend
|
|
||
| return ( | ||
| <Fragment> | ||
| {hasPageFrame ? ( | ||
| <PrimaryNavigation.Button | ||
| label={t('Search support, docs and more')} |
There was a problem hiding this comment.
Would adding a "(cmd+k)" prompt be good to add to the label so users can learn the shortkey?
Would need to accommodate windows too, and additionally would love if we could have a kbd component like https://ui.shadcn.com/docs/components/radix/kbd
This can always come later, just an idea though
There was a problem hiding this comment.
Adding a kbd component has been on our list! Happy to tackle that in a follow-up
There was a problem hiding this comment.
I think we do actually have something somewhere already, I just cant remember the name of it rn
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| <MenuIcon> | ||
| <IconSearch /> | ||
| </MenuIcon> | ||
| ) : undefined, |
There was a problem hiding this comment.
Dead hasPageFrame check inside !hasPageFrame branch
Low Severity
The leadingItems: hasPageFrame ? ... : undefined conditional on the search menu item is now inside the !hasPageFrame branch of the outer ternary (lines 52-70), so hasPageFrame is always false here. This means leadingItems is always undefined, making the ternary dead code. It looks like a leftover from before the refactor that moved the search item into the conditional — it can be simplified by just removing the leadingItems property entirely.
The search item is only rendered in the !hasPageFrame branch, so the hasPageFrame ternary on leadingItems was always false and always produced undefined. Remove the dead code and the now-unused IconSearch import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 participants
Promotes CMD+K action to primary nav when page-frame is enabled and replaces the help menu search when cmd+k supercharged flag is enabled
Pending feature flag release, but this fixes DE-722