fix(nav): Restore focus to previous element after closing command palette#111445
Open
jshchnz wants to merge 1 commit intofeat/cmd-k-togglefrom
Open
fix(nav): Restore focus to previous element after closing command palette#111445jshchnz wants to merge 1 commit intofeat/cmd-k-togglefrom
jshchnz wants to merge 1 commit intofeat/cmd-k-togglefrom
Conversation
…ette The GlobalModal's focus-trap doesn't reliably return focus because the command palette input's autoFocus moves focus into the portal before the trap activates, causing it to store the wrong "previous" element. Explicitly save document.activeElement when opening the palette and restore it when the modal closes, regardless of close method.
rbro112
approved these changes
Mar 24, 2026
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoFocusmoves focus into the portal before the trap'sactivate()runs, causing it to store the wrong "previous" elementdocument.activeElementexplicitly when opening the palette and restores it when the modal closes (via any method: Escape, backdrop click, Cmd+K toggle, route change)Depends on #111441
Test plan