Conversation
github-actions
bot
added
the
Scope: Frontend
billyvg
commented
Mar 25, 2026
Member
Author
There was a problem hiding this comment.
actually I'm gonna revert the changes to this file for now
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ryan953
reviewed
Mar 25, 2026
Comment on lines
+210
to
+219
| /** | ||
| * Pure function for non-hook contexts (e.g. buildIntegrationTreeNodes). | ||
| * Returns true if the provider is in the supported list. | ||
| */ | ||
| export function isSeerSupportedProvider( | ||
| provider: {id: string; name: string}, | ||
| supportedProviderIds: string[] | ||
| ): boolean { | ||
| return supportedProviderIds.includes(provider.id); | ||
| } |
Member
There was a problem hiding this comment.
could probably remove this helper, the new hook that returns the list is doing all the work really.
Member
Author
There was a problem hiding this comment.
ah there are some places that use it (e.g. outside of a react component)
ryan953
approved these changes
Mar 25, 2026
Member
ryan953
left a comment
ryan953
left a comment
There was a problem hiding this comment.
isSupportedProvider updated in all the places!
If an org has seat-based billing enabled _and_ have the `seer-gitlab-support` feature flag enabled, then allow GitLab to be configurable for Seer. Note that only internal Sentry orgs have the gitlab feature flag enabled.
This reverts commit 8f76402.
billyvg
force-pushed
the
billyvong/cw-1018-change-ui-for-seer-settings-to-allow-support-for-gitlab
branch
from
9f82085 to
0c32a46
Compare
billyvg
deleted the
billyvong/cw-1018-change-ui-for-seer-settings-to-allow-support-for-gitlab
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an org has seat-based billing enabled and have the
seer-gitlab-supportfeature flag enabled, then allow GitLab to be configurable for Seer. Note that only internal Sentry orgs have the gitlab feature flag enabled.