fix(explore): Always show selected metric first in metric selector#111448
Merged
nsdeschenes merged 2 commits intomasterfrom Mar 25, 2026
Merged
Conversation
When reopening the metric selector dropdown, the selected metric now always appears at the top of the list. Previously it only appeared first on page refresh when the API hadn't returned it yet; otherwise it stayed in its alphabetical position. Refs LOGS-634 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Align selectedMetricValue computation with the rest of the file by conditionally stripping the unit field when hasMetricUnitsUI is false. Without this, the find and filter comparisons against API option values would fail to match, causing the selected metric to appear twice. Refs LOGS-634 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
narsaynorath
approved these changes
Mar 24, 2026
nsdeschenes
deleted the
nd/LOGS-634/fix-tracemetrics-selected-metric-not-first
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the metrics selector so that the selected option is always at the top of the list. With the refactor to the new dropdown with this was not happening as expected.
Refs LOGS-634