Conversation
The X-axis selector for categorical bar charts was filtering to only string-typed tags, excluding valid numeric tags like run_id and HTTP status codes. This made it impossible to group by these tags directly in the bar chart builder. Fetch both string and number attributes for EAP datasets and accept both types in the non-EAP filter, matching the behavior of the groupBy selector used in timeseries charts. Refs DAIN-1400 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Mar 25, 2026
gggritso
deleted the
georgegritsouk/dain-1400-bar-chart-x-axis-is-missing-run_id-tag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X-axis selector for categorical bar charts was filtering to only string-typed tags, excluding valid numeric tags like
run_idand HTTP status codes. This made it impossible to group by these tags directly in the bar chart builder. I did this on purpose to prevent people from using high-cardinality values as groups but I changed my mind, there are a whole bunch of compelling reasons for people to do this (e.g., HTTP response codes) and it's not wise to just forbid it! We should probably allow boolean tags, too.Users have to manually specify the limit of how many groups to plot, and it's <25, so the worst case scenario is they make a very silly chart with a high-cardinality X-axis like this:
On the flip side, you can make exciting charts like this, grouping by HTTP response code!
There was also a related bug where users could get numeric tags as the X-axis by setting a groupBy in timeseries mode and then switching to categorical bar — but the tag was then unselectable in the X-axis dropdown.
Refs DAIN-1400