Skip to content

ref(nav) condense nav#111468

Merged
JonasBa merged 2 commits intomasterfrom
jb/ref/nav-primary-hover
Mar 25, 2026
Merged

ref(nav) condense nav#111468
JonasBa merged 2 commits intomasterfrom
jb/ref/nav-primary-hover

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 24, 2026

Condenses links in the nav such that cursor actions passing through multiple items no longer pass stack gap sections and cause a cursor flicker while the visual spacing remains preserved.

@JonasBa JonasBa requested a review from a team as a code owner March 24, 2026 21:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2026
position="relative"
margin="0"
padding={hasPageFrame ? 'xs' : '0'}
padding={hasPageFrame ? 'xs xs lg xs' : '0'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit tight now, can we keep the existing spacing but still switch to padding? Think xl or 2xl might do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try xl!

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonasBa JonasBa changed the title ref(nav) consense nav ref(nav) condense nav Mar 25, 2026
@JonasBa JonasBa merged commit 93e1c2f into master Mar 25, 2026
72 checks passed
@JonasBa JonasBa deleted the jb/ref/nav-primary-hover branch March 25, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants