Skip to content

fix(snapshots): Disable CSS animations for snapshot testing#111485

Merged
rbro112 merged 1 commit intomasterfrom
ryan/disable_css_animations_for_snapshot_testing
Mar 24, 2026
Merged

fix(snapshots): Disable CSS animations for snapshot testing#111485
rbro112 merged 1 commit intomasterfrom
ryan/disable_css_animations_for_snapshot_testing

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Mar 24, 2026

A recent flake in radio.tsx was caused by an animation on the checked state. After some investigation, this caused flakes in our snapshot suite as small timing differences resulted in some minor diffs in the checked state, indicating the animation wasn't completing.

This will disable CSS animations in our snapshot tests to ensure stability.

@rbro112 rbro112 requested a review from a team as a code owner March 24, 2026 22:35
Copy link
Member Author

rbro112 commented Mar 24, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2026
@rbro112 rbro112 changed the title Disable CSS animations for snapshot testing fix(snapshots): Disable CSS animations for snapshot testing Mar 24, 2026
@rbro112 rbro112 merged commit a8a5621 into master Mar 24, 2026
72 checks passed
@rbro112 rbro112 deleted the ryan/disable_css_animations_for_snapshot_testing branch March 24, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants