ref(workflows): Use WorkflowId directly instead of _ActionFilterCacheKey when caching action filters

[kcons]

Should be functionally equivalent, but less wordy.

[kcons]

Thoughts? Visually clearer, but arguably marginally less safe.

[saponifi3d]

I'm down, i think the cache mapping layer gives us that layer of protection to drop the cache access. Is the hope that we can eventually fully remove CacheAccess or keeping it around for composite keys?

[kcons]

I'm down, i think the cache mapping layer gives us that layer of protection to drop the cache access. Is the hope that we can eventually fully remove CacheAccess or keeping it around for composite keys?

Might be misunderstanding, but CacheAccess is already gone. This change is moving from a wrapper type around WorkflowId as a key to just using WorkflowId directly; this is intentionally supported in the CacheMapping design, as the key derivation lives in the class and not in the key type, which means we can use anything comparable as a key. It just so happens that many keys are composite and made up of one or more ints, and for those it's much clearer to have an explicit key type so we always do, but in the case of single items (or unambiguous existing types) we don't really need the cache class wrapper.