Skip to content

fix(seer): render explorer panel when page-frame feature is enabled#111502

Merged
JonasBa merged 2 commits intomasterfrom
jb/seer/panel
Mar 25, 2026
Merged

fix(seer): render explorer panel when page-frame feature is enabled#111502
JonasBa merged 2 commits intomasterfrom
jb/seer/panel

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 25, 2026

The early return was preventing the panel from ever rendering - we should have only disabled the trigger (floating point when that is the case)

When hasPageFrame is true, ExplorerPanel was returning null entirely,
preventing the panel from ever rendering even when opened via the Ask
Seer button in the TopBar. Remove the early return and instead
conditionally render only the floating action button when page-frame
is disabled.

Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 25, 2026
@JonasBa JonasBa requested a review from indragiek March 25, 2026 01:53
@JonasBa JonasBa marked this pull request as ready for review March 25, 2026 01:53
@JonasBa JonasBa requested a review from a team as a code owner March 25, 2026 01:53
@JonasBa JonasBa requested a review from Zylphrex March 25, 2026 01:53
@JonasBa JonasBa changed the title fix(seer): Render explorer panel when page-frame feature is enabled fix(seer): render explorer panel when page-frame feature is enabled Mar 25, 2026
@JonasBa JonasBa merged commit a49fd27 into master Mar 25, 2026
74 checks passed
@JonasBa JonasBa deleted the jb/seer/panel branch March 25, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants