feat(nav): add cmd/ctrl+b nav toggle hotkey#111503
Merged
Conversation
Add a keyboard shortcut (Cmd+B on macOS, Ctrl+B on Windows/Linux) to toggle the secondary sidebar between expanded and collapsed states. This follows the convention established by VS Code, Zed, and Cursor, which all use the same binding, making it the de-facto standard for sidebar toggling in modern developer tools. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
JonasBa
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The hotkey callback had the toggle condition inverted relative to the button logic. Using 'view === collapsed ? expanded : collapsed' treated the peek state as expanded and would collapse it, while the button correctly treats peek as collapsed and expands it. Fix by aligning the hotkey condition with the button: 'view === expanded ? collapsed : expanded' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Two test functions used async without any await expressions, triggering the @typescript-eslint/require-await lint rule. Since fireEvent is synchronous, async is not needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a keyboard shortcut (Cmd+B on macOS, Ctrl+B on Windows/Linux) to toggle the secondary sidebar between expanded and collapsed states.