Conversation
…value When tag values fail to load, the options array only contains the already-selected values. The isAllSelected check compared activeFilterValues.length against options.length, which was always true in this case, incorrectly showing "All" as the trigger label. Remove the options.length comparison so "All" only shows when no filter values are selected. Also fix the multi-select trigger to use activeFilterValues instead of stagedFilterValues for consistency with the single-select path. Refs DAIN-1407 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
gggritso
deleted the
georgegritsouk/dain-1407-global-filter-label-doesnt-match-internal-value
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the global filter selector trigger displaying "All" when a specific value is saved but tag values fail to load.
e.g.,
Two bugs combined to cause this:
The trigger rendered
stagedFilterValues(in-flight dropdown state) instead ofactiveFilterValues(the committed filter). Before the dropdown was opened, staged values were empty → "All".isAllSelectedcompared againstoptions.length. When tag values failed to load,optionsonly contained the already-selected values, making the comparison a tautology. Now it simply checks for an empty selection.Refs DAIN-1407