ref(tracemetrics): Remove unsortable telemetry columns behind feature flag#111518
Merged
nsdeschenes merged 2 commits intoMar 30, 2026
Merged
Conversation
k-fish
approved these changes
Mar 30, 2026
When the tracemetrics-ui-refresh flag is enabled, filter out the unsortable telemetry columns (logs, spans, errors) from the samples table and skip the three additional API queries that fetch their data. Also simplify the side-by-side panel split calculation since the telemetry icon width no longer needs to be accommodated. Refs LOGS-631 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sh flag Add test asserting that Logs, Spans, and Errors column headers are not rendered in the samples table when tracemetrics-ui-refresh is enabled. Refs LOGS-631 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
222de9c to
ae97160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the unsortable telemetry columns (Logs, Spans, Errors) from the trace metrics samples table when
canUseMetricsUIRefreshis enabled.This is the first step in some changes to the samples table as part of the metrics UI refresh.
Refs LOGS-631
Example: