fix(spans): Exclude segment span from breakdown computation#111520
Merged
fix(spans): Exclude segment span from breakdown computation#111520
Conversation
compute_breakdowns was including the segment span itself when computing operation-based time breakdowns. When the segment root span had an op matching the breakdown config (e.g. http.server matching "http"), its full duration was counted, inflating the breakdown to the entire segment length instead of reflecting only child span durations. Filter out the segment span at the call site before passing spans to compute_breakdowns, and rename the parameter to child_spans to signal the expected input. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
gggritso
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_breakdownswas including the segment span itself when computing operation-based time breakdowns. When the segment root span had an op matching the breakdown config (e.g. http.server matching "http"), its full duration was counted, inflating the breakdown to the entire segment length instead of reflecting only child span durations.Filter out the segment span at the call site before passing spans to
compute_breakdowns, and rename the parameter tochild_spansto signal the expected input.