ref(metrics): Tidy up metrics UI for refresh layout#111532
Conversation
github-actions
Bot
added
the
Scope: Frontend
Match the spans tab pattern where the visualize label shows a letter (A, B, C) when visible and swaps to a closed eye icon when hidden, instead of always showing an eye icon. Only applies when the metrics UI refresh flag is enabled. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
Hide the MetricInfoTabs component entirely when the metrics UI refresh flag is enabled, removing the Samples and Aggregates tab sections from the metric panel. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
Restore MetricInfoTabs in the refresh layout, but only render it when the metric's visualize is visible. When the metric is hidden via the label toggle, the tabs are hidden along with the chart. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
nsdeschenes
force-pushed
the
nd/chore-tracemetrics-tidy-up-hiding-metrics
branch
from
6d640b2 to
087fd01
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| width: 24px; | ||
| height: 36px; | ||
| border-radius: ${p => p.theme.radius.md}; | ||
| `; |
There was a problem hiding this comment.
New styled component duplicates existing Label component
Low Severity
The new RefreshLabel styled component and the refresh-path rendering logic closely duplicate the existing Label component and VisualizeLabel function in toolbarVisualize.tsx (lines 279–296). Both implement identical styling (cursor, border-radius, accent background, accent color, 24×36px dimensions, centered flex). Since the PR intends to "match the pattern used in the spans tab," extracting this shared label styling into a reusable component would prevent future drift between the two.
Additional Locations (1)
2 participants
Update the metrics explore tab when the UI refresh flag is enabled:
Examples: