ref(seer): Delete Seer settings ProjectOption rows instead of writing defaults#111543
Merged
ref(seer): Delete Seer settings ProjectOption rows instead of writing defaults#111543
Conversation
When writing Seer project preferences, delete the ProjectOption row when the value matches the registered default. This lets us distinguish "never configured" from "configured with defaults" by checking for row existence, which simplifies the upcoming read-from-Sentry-DB migration. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Backend
srest2021
changed the title
JoshFerge
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing Seer project preferences, delete the ProjectOption row when the value matches the registered default. This lets us distinguish "never configured" from "configured with defaults" by checking for SeerProjectRepository and ProjectOption existence, which simplifies the upcoming dual-read from Sentry DB and allows us to return null preference for never-configured projects. Also, we don't needlessly store default project options.