Skip to content

chore(ci): Add configurable timeout to setup-sentry composite action #111561

Merged
kenzoengineer merged 2 commits intomasterfrom
kjiang/setup-sentry-env-timeout
Mar 25, 2026
Merged

chore(ci): Add configurable timeout to setup-sentry composite action #111561
kenzoengineer merged 2 commits intomasterfrom
kjiang/setup-sentry-env-timeout

Conversation

@kenzoengineer
Copy link
Member

@kenzoengineer kenzoengineer commented Mar 25, 2026

Sometimes github throws a tantrum and setup-sentry hangs, causing the calling action to timeout. Our median run time for this action is ~1.5minutes, so we really shouldn't be letting this action run loose.

This PR adds a configurable timeout (default 10 min) to the devservices up call so we can exit earlier. Uses the native linux timeout command.

Other options explored

  • timeout-minutes still isn't supported in composite actions, a feature request has been open for years: Support timeout-minutes in composite-actions actions/runner#1979
  • Putting a timeout-minutes on every single step that uses this action is possible but annoying, we already use this action in ~17 different places.
  • Wrapping this in a reusable workflow will allow us to set a timeout, but reusable workflows run in their own runner and are aren't useful for setting up an environment for another workflow

@kenzoengineer kenzoengineer requested a review from a team March 25, 2026 20:57
@kenzoengineer kenzoengineer marked this pull request as ready for review March 25, 2026 20:57
@kenzoengineer kenzoengineer requested a review from a team as a code owner March 25, 2026 20:57
Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow til timeout

@github-actions
Copy link
Contributor

Backend Test Failures

Failures on d99296d in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registeredlog
tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.workflow_engine.tasks.cleanup
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

@kenzoengineer kenzoengineer disabled auto-merge March 25, 2026 21:36
@kenzoengineer
Copy link
Member Author

backend failures are unrelated

@kenzoengineer kenzoengineer merged commit 9eefb2e into master Mar 25, 2026
78 of 81 checks passed
@kenzoengineer kenzoengineer deleted the kjiang/setup-sentry-env-timeout branch March 25, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants