chore(ci): Add configurable timeout to setup-sentry composite action #111561
Merged
kenzoengineer merged 2 commits intomasterfrom Mar 25, 2026
Merged
chore(ci): Add configurable timeout to setup-sentry composite action #111561kenzoengineer merged 2 commits intomasterfrom
kenzoengineer merged 2 commits intomasterfrom
Conversation
Contributor
Backend Test FailuresFailures on
|
Member
Author
|
backend failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes github throws a tantrum and
setup-sentryhangs, causing the calling action to timeout. Our median run time for this action is ~1.5minutes, so we really shouldn't be letting this action run loose.This PR adds a configurable timeout (default 10 min) to the
devservices upcall so we can exit earlier. Uses the native linuxtimeoutcommand.Other options explored
timeout-minutesstill isn't supported in composite actions, a feature request has been open for years: Support timeout-minutes in composite-actions actions/runner#1979timeout-minuteson every single step that uses this action is possible but annoying, we already use this action in ~17 different places.