Skip to content

ref(seer): Use signed API for grouping record project delete#111610

Merged
chromy merged 2 commits intomasterfrom
chromy/ref/signed-seer-grouping-record-delete
Mar 26, 2026
Merged

ref(seer): Use signed API for grouping record project delete#111610
chromy merged 2 commits intomasterfrom
chromy/ref/signed-seer-grouping-record-delete

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Mar 26, 2026

Move the project grouping record delete endpoint (/v0/issues/similar-issues/grouping-record/delete) to use make_signed_seer_api_request instead of a raw unsigned urlopen call, consistent with all other Seer API methods.

  • Add make_delete_grouping_records_by_project_request to signed_seer_api.py with a DeleteGroupingRecordsByProjectRequest typed dict
  • Add seer_grouping_default_connection_pool using settings.SEER_GROUPING_URL
  • Update call_seer_to_delete_project_grouping_records to use the new signed method (this also resolves the existing TODO comment about moving to POST)

Agent transcript: https://claudescope.sentry.dev/share/yp4ee9srss2V1UbfuaaD-PJyoIAqYGErBGG8WwuRn-I

Move the project grouping record delete endpoint to use
make_signed_seer_api_request instead of raw unsigned urlopen,
consistent with all other Seer API methods.

Add make_delete_grouping_records_by_project_request to
signed_seer_api.py and update the caller in grouping_records.py.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Agent transcript: https://claudescope.sentry.dev/share/F9xIxA3h-XKZnxB0d67SSbbqhx5WMdNbjRfunu1S6OQ
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 26, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@chromy chromy force-pushed the chromy/ref/signed-seer-grouping-record-delete branch from 7957732 to 6ba8139 Compare March 26, 2026 12:37
@chromy chromy requested a review from a team as a code owner March 26, 2026 12:37
@chromy chromy merged commit fea632f into master Mar 26, 2026
105 of 106 checks passed
@chromy chromy deleted the chromy/ref/signed-seer-grouping-record-delete branch March 26, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants