perf(workflows): Batch ActionAlertRuleTriggerAction lookup in WorkflowEngineActionSerializer#111763
Merged
Conversation
…wEngineActionSerializer
github-actions
Bot
added
the
Scope: Backend
saponifi3d
approved these changes
Mar 27, 2026
|
|
||
| class WorkflowEngineActionSerializer(Serializer): | ||
| def get_attrs( | ||
| self, item_list: Sequence[Action], user: User | RpcUser | AnonymousUser, **kwargs: Any |
Contributor
There was a problem hiding this comment.
just for my own learning -- do you happen to know what the difference between Sequence, Collection, and list would be for mypy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a query per action, and makes further refactors to improve batching more effective.