Skip to content

chore(dashboards): Add consistent settings files to all prebuilt dashboard configs#111788

Merged
DominikB2014 merged 2 commits into
masterfrom
dominikbuszowiecki/browse-474-cleanup-settingsts-files
Mar 30, 2026
Merged

chore(dashboards): Add consistent settings files to all prebuilt dashboard configs#111788
DominikB2014 merged 2 commits into
masterfrom
dominikbuszowiecki/browse-474-cleanup-settingsts-files

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

Summary

  • Add settings.ts files to ai/, mobileVitals/, and webVitals/ prebuilt dashboard config folders that were missing them
  • Consolidate queries/constants.ts into queries/settings.ts so titles and constants live in one place
  • All dashboard titles are now centralized in settings files with proper t() i18n wrapping (previously AI and webVitals titles were plain strings)
  • Updated 15 config files to import their dashboard titles from the new settings files

Test plan

  • Verify prebuilt dashboards still render correctly with their expected titles
  • Confirm no regressions in dashboard creation flow

…board configs

Add settings.ts files to ai/, mobileVitals/, and webVitals/ folders that
were missing them, and consolidate queries/constants.ts into queries/settings.ts.
All dashboard titles are now centralized in settings files with proper i18n
wrapping via t().
@DominikB2014 DominikB2014 requested a review from a team as a code owner March 30, 2026 15:23
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Mar 30, 2026

@DominikB2014 DominikB2014 marked this pull request as draft March 30, 2026 15:23
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 30, 2026
@DominikB2014 DominikB2014 marked this pull request as ready for review March 30, 2026 15:25
Copy link
Copy Markdown
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Contributor

@jameskeane jameskeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on variable naming, otherwise lgtm

Comment thread static/app/views/dashboards/utils/prebuiltConfigs/queries/querySummary.ts Outdated
…TITLE

Rename the constant and associated exported configs across all prebuilt
dashboard configs that use it. Also rename the corresponding files from
*Summary.ts to *Details.ts for consistency.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@DominikB2014 DominikB2014 merged commit dd2f2ec into master Mar 30, 2026
74 of 75 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-474-cleanup-settingsts-files branch March 30, 2026 16:19
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants