ref(navigation): Hide page-level FeedbackButtons when page-frame is enabled#111826
Draft
ref(navigation): Hide page-level FeedbackButtons when page-frame is enabled#111826
Conversation
…nabled The TopBar now renders a global FeedbackButton for all pages when the page-frame feature is enabled. Hide the per-page FeedbackButton instances to avoid duplicates, while keeping usages inside modals and overlays unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide per-page
FeedbackButtoninstances when thepage-framefeature flag is enabled.The TopBar (
views/navigation/topBar.tsx) now renders a globalFeedbackButtonfor all pages under the page-frame feature. Having individual feedback buttons on every page header alongside the TopBar one results in duplicates.This adds a
useHasPageFrameFeature()check to all 39 page-level usages so they return/render nothing when the flag is on. Usages inside modals and overlays (command palette, replay comparison modal, search filter dropdown) are intentionally left unchanged since the TopBar is not visible in those contexts.Wrapper components (
AutofixFeedback,AutomationFeedbackButton,MonitorFeedbackButton,DynamicAlertsFeedbackButton) use an earlyreturn null. Direct page-level usages gate the JSX with{!hasPageFrame && <FeedbackButton />}.