Skip to content

feat(seer): Update default triggers for Code Review#111829

Merged
ryan953 merged 1 commit into
masterfrom
ryan953/code-review-default-triggers
Mar 31, 2026
Merged

feat(seer): Update default triggers for Code Review#111829
ryan953 merged 1 commit into
masterfrom
ryan953/code-review-default-triggers

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Mar 30, 2026

@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Mar 30, 2026

Copy link
Copy Markdown
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the UX on top to be clear to the user what they are getting

@ryan953 ryan953 merged commit 128112a into master Mar 31, 2026
94 of 96 checks passed
@ryan953 ryan953 deleted the ryan953/code-review-default-triggers branch March 31, 2026 15:44
@ryan953 ryan953 added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Mar 31, 2026
@getsentry-bot
Copy link
Copy Markdown
Contributor

PR reverted: e24356d

getsentry-bot added a commit that referenced this pull request Mar 31, 2026
This reverts commit 128112a.

Co-authored-by: ryan953 <187460+ryan953@users.noreply.github.com>
@ryan953
Copy link
Copy Markdown
Member Author

ryan953 commented Mar 31, 2026

Reverted because of failing test. The selective test runner missed it, and so master CI failed.

Reverted to unblock, re-implemented in #111911

@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on 128112a in this run:

tests/sentry/integrations/api/endpoints/test_organization_repository_details.py::OrganizationRepositoryGetTest::test_get_repository_expand_settings_no_settings_existlog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/api/endpoints/test_organization_repository_details.py:91: in test_get_repository_expand_settings_no_settings_exist
    assert response.data["settings"]["codeReviewTriggers"] == [
E   AssertionError: assert ['on_ready_for_review'] == ['on_ready_fo...n_new_commit']
E     
E     Right contains one more item: 'on_new_commit'
E     
E     Full diff:
E       [
E           'on_ready_for_review',
E     -     'on_new_commit',
E       ]

ryan953 added a commit that referenced this pull request Mar 31, 2026
This is a repeat of #111829 

That #111829 was reverted because of a failing test: the selective test
runner didn't find the test so i missed it.
dashed pushed a commit that referenced this pull request Apr 1, 2026
This reverts commit 128112a.

Co-authored-by: ryan953 <187460+ryan953@users.noreply.github.com>
dashed pushed a commit that referenced this pull request Apr 1, 2026
This is a repeat of #111829 

That #111829 was reverted because of a failing test: the selective test
runner didn't find the test so i missed it.
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants