ref(cells): Update slack and discord tasks to accept cell_name#111858
Merged
Conversation
…name Update the convert_to_async_slack_response and convert_to_async_discord_response tasks to also accept cell_name. Once deployed everywhere, will update callers to pass cell_name
github-actions
Bot
added
the
Scope: Backend
markstory
approved these changes
Mar 31, 2026
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good. There are no callers of this task that are using positional arguments so moving the parameters around will be safe.
lynnagara
added a commit
that referenced
this pull request
Mar 31, 2026
…onvert_to_async_slack_response Follow up to #111858, now workers are fully updated it is now safe to update callers to pass the new parameter
dashed
pushed a commit
that referenced
this pull request
Apr 1, 2026
Update the convert_to_async_slack_response and convert_to_async_discord_response tasks to also accept cell_name. Once deployed everywhere, will update callers to pass cell_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the convert_to_async_slack_response and convert_to_async_discord_response tasks to also accept cell_name.
Once deployed everywhere, will update callers to pass cell_name