Skip to content

chore(ACI): Update front end usage of detector create endpoint to project scoped one#111933

Merged
ceorourke merged 2 commits intomasterfrom
ceorourke/ISWF-2309
Apr 2, 2026
Merged

chore(ACI): Update front end usage of detector create endpoint to project scoped one#111933
ceorourke merged 2 commits intomasterfrom
ceorourke/ISWF-2309

Conversation

@ceorourke
Copy link
Copy Markdown
Member

In #110285 we created a project scoped version of the OrganizationDetectorIndex POST method and this PR updates the front end usage of it so we can move towards removing it.

@linear-code
Copy link
Copy Markdown

linear-code bot commented Mar 31, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 31, 2026
@ceorourke ceorourke marked this pull request as ready for review April 1, 2026 22:08
@ceorourke ceorourke requested a review from a team as a code owner April 1, 2026 22:08
getApiUrl(
'/organizations/$organizationIdOrSlug/projects/$projectIdOrSlug/detectors/',
{
path: {organizationIdOrSlug: org.slug, projectIdOrSlug: data.projectId},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that the BaseDetectorUpdatePayload already includes the project id 🎉

@ceorourke ceorourke merged commit 54c9b67 into master Apr 2, 2026
74 checks passed
@ceorourke ceorourke deleted the ceorourke/ISWF-2309 branch April 2, 2026 17:06
ceorourke added a commit that referenced this pull request Apr 2, 2026
)

We are [no longer
using](#111933) the org scoped
detector creation endpoint in favor of the project scoped one so we can
remove the code. I copied over one test that was missing in the project
scoped endpoint.

Not to be merged until #112057
is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants