perf(workflows): Avoid excessive querying in WorkflowEngineRuleSerializer

[kcons]

The previous logic had us potentially sending 100+ workflow queries, which can add 300ms+ to the request.
By only fetching ids, we avoid considerable unnecessary work.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Missing project crashes workflow serialization
  • Changed direct dict indexing to use .get() with a None check to gracefully skip projects that are not returned by get_many_from_cache().

Or push these changes by commenting:

@cursor push fc2aeaafd0

Preview (fc2aeaafd0)

diff --git a/src/sentry/api/serializers/models/rule.py b/src/sentry/api/serializers/models/rule.py
--- a/src/sentry/api/serializers/models/rule.py
+++ b/src/sentry/api/serializers/models/rule.py
@@ -410,7 +410,9 @@
         )
         projects_by_id = {project.id: project for project in projects}
         for workflow_id, project_id in workflows_to_project_ids:
-            workflow_to_projects[workflow_id].add(projects_by_id[project_id])
+            project = projects_by_id.get(project_id)
+            if project is not None:
+                workflow_to_projects[workflow_id].add(project)
 
         return workflow_to_projects

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[github-actions]

Backend Test Failures

Failures on 94be229 in this run:

tests/sentry/api/serializers/test_rule.py::WorkflowRuleSerializerTest::test_fetch_workflow_projects — log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/api/serializers/test_rule.py:207: in test_fetch_workflow_projects
    assert workflow_projects == {
E   AssertionError: assert defaultdict(<...9006796832>}}) == {<Workflow at...89006796832>}}
E     
E     Left contains 2 more items:
E     {198: {<Project at 0x7f3b810ded00: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>},
E      199: {<Project at 0x7f3b78a91570: id=4557889006796833, team_id=None, name='Exciting Sparrow', slug='exciting-sparrow', organization_id=4557889006796832>,
E            <Project at 0x7f3b810dfad0: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>}}
E     Right contains 2 more items:
E     {<Workflow at 0x7f3b762ef690: id=199, organization_id=4557889006796835>: {<Project at 0x7f3b752d2b60: id=4557889006796833, team_id=None, name='Exciting Sparrow', slug='exciting-sparrow', organization_id=4557889006796832>,
E                                                                               <Project at 0x7f3b7a06e680: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>},
E      <Workflow at 0x7f3b7858a970: id=198, organization_id=4557889006796834>: {<Project at 0x7f3b7a06e680: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>}}
E     
E     Full diff:
E     + defaultdict(<class 'set'>, {
E     +     198: {
E     - {
E     -     <Workflow at 0x7f3b762ef690: id=199, organization_id=4557889006796835>: {
E     -         <Project at 0x7f3b752d2b60: id=4557889006796833, team_id=None, name='Exciting Sparrow', slug='exciting-sparrow', organization_id=4557889006796832>,
E     -         <Project at 0x7f3b7a06e680: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>,
E     ?                           ^^ ^ ^^
E     +         <Project at 0x7f3b810ded00: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>,
E     ?                           ^^ ^ ^^
E           },
E     -     <Workflow at 0x7f3b7858a970: id=198, organization_id=4557889006796834>: {
E     +     199: {
E     +         <Project at 0x7f3b78a91570: id=4557889006796833, team_id=None, name='Exciting Sparrow', slug='exciting-sparrow', organization_id=4557889006796832>,
E     -         <Project at 0x7f3b7a06e680: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>,
E     ?                           ^ ^^^^^
E     +         <Project at 0x7f3b810dfad0: id=4557889006796832, team_id=None, name='Bar', slug='bar', organization_id=4557889006796832>,
E     ?                           ^^^^^ ^
E           },
E     - }
E     + })