fix(grouping): Fix git sha parameterization test#111964
Merged
lobsterkatie merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
JoshFerge
approved these changes
Mar 31, 2026
dashed
pushed a commit
that referenced
this pull request
Apr 1, 2026
We have a parameterization test case for our git sha parameterization which was meant to show that if the value doesn't include any numbers, it doesn't match our the pattern. But our git sha pattern only matches strings with exactly 7 characters, and the test case currently has 8, so of course it doesn't match! This fixes things so we're actually testing against a valid git sha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a parameterization test case for our git sha parameterization which was meant to show that if the value doesn't include any numbers, it doesn't match our the pattern. But our git sha pattern only matches strings with exactly 7 characters, and the test case currently has 8, so of course it doesn't match! This fixes things so we're actually testing against a valid git sha.