Skip to content

fix(seer): don't read from org defaults when creating default project preference#111967

Merged
srest2021 merged 2 commits intomasterfrom
srest2021/fix-default-project-preference
Apr 1, 2026
Merged

fix(seer): don't read from org defaults when creating default project preference#111967
srest2021 merged 2 commits intomasterfrom
srest2021/fix-default-project-preference

Conversation

@srest2021
Copy link
Copy Markdown
Member

@srest2021 srest2021 commented Mar 31, 2026

I made this change in my previous PR which I now realize is incorrect. This needs to read from project preferences and can be updated once the settings migration is complete. For now we can just use CODE_CHANGES.

Functionally there is not much difference between the two except the change in my previous PR allows the autoOpenPrs org option to override the stopping point. The project preference should always have the correct stopping point. Let's change it back.

@srest2021 srest2021 requested a review from a team as a code owner March 31, 2026 23:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/sentry/seer/autofix/utils.py Outdated
Comment thread src/sentry/seer/autofix/utils.py Outdated
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a test to confirm behavior?

@srest2021 srest2021 merged commit 7cab0a1 into master Apr 1, 2026
73 checks passed
@srest2021 srest2021 deleted the srest2021/fix-default-project-preference branch April 1, 2026 00:08
dashed pushed a commit that referenced this pull request Apr 1, 2026
… preference (#111967)

I made [this
change](https://github.com/getsentry/sentry/pull/111697/changes#diff-204df1d50b6d80eb112a1bafcdc4bb853e274f0e56ae3e082897b201aa0de550L391-L392)
in my previous PR which I now realize is incorrect. This needs to read
from project preferences and can be updated once the settings migration
is complete. For now we can just use CODE_CHANGES.

Functionally there is not much difference between the two except the
change in my previous PR allows the autoOpenPrs org option to override
the stopping point. The project preference should always have the
correct stopping point. Let's change it back.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants